Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #24519

%2\$; is not valid. On php7 this is just ignored but on php8 it gives an
error. %2\$s; works.

Signed-off-by: Roeland Jago Douma <[email protected]>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Dec 3, 2020
@MorrisJobke MorrisJobke mentioned this pull request Dec 3, 2020
@faily-bot
Copy link

faily-bot bot commented Dec 3, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 109: failure

mariadb10.2-php7.2

Show full log
There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

--

There was 1 failure:

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testDeleteUser with data set #3 ('a', 'b', 'c', 'd', false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:761

mysql5.6-php7.2

Show full log
There was 1 error:

1) Test\SystemTag\SystemTagManagerTest::testDeleteTags
OCP\SystemTag\TagNotFoundException: Tag id(s) not found

/drone/src/lib/private/SystemTag/SystemTagManager.php:326
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:390

Caused by
OCP\SystemTag\TagNotFoundException: Tag id(s) not found

/drone/src/lib/private/SystemTag/SystemTagManager.php:125
/drone/src/lib/private/SystemTag/SystemTagManager.php:291
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:390

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

mysqlmb4-php7.3

Show full log
There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopy with data set #7 ('/single ' quote.txt', '/tar'get.txt')
Expected /tar'get.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
-Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
-Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
-Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+''

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:235

integration-ldap-openldap-features

  • failure block could not be found - most likely this run got canceled
Show full log
+ bash tests/drone-run-integration-tests.sh || exit 0
=========================
= List of changed files =
=========================
=========================
No files are modified => merge commit
+ ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
Nextcloud was successfully installed
+ ./occ config:system:set redis host --value=cache
System config value redis => host set to string cache
+ ./occ config:system:set redis port --value=6379 --type=integer
System config value redis => port set to integer 6379
+ ./occ config:system:set redis timeout --value=0 --type=integer
System config value redis => timeout set to integer 0
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.local
System config value memcache.local set to string \OC\Memcache\Redis
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.distributed
PHP Warning:  Redis::connect(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /drone/src/lib/private/RedisFactory.php on line 92
An unhandled exception has been thrown:
RedisException: Redis server went away in /drone/src/lib/private/Memcache/Redis.php:55
Stack trace:
#0 /drone/src/lib/private/Memcache/Redis.php(55): Redis->get('0e1dc8a851da446...')
#1 /drone/src/lib/private/App/InfoParser.php(58): OC\Memcache\Redis->get('/drone/src/apps...')
#2 /drone/src/lib/private/App/AppManager.php(511): OC\App\InfoParser->parse('/drone/src/apps...')
#3 /drone/src/lib/private/legacy/OC_App.php(558): OC\App\AppManager->getAppInfo('files', false, NULL)
#4 /drone/src/lib/private/AppFramework/App.php(68): OC_App::getAppInfo('files')
#5 /drone/src/lib/private/legacy/OC_App.php(241): OC\AppFramework\App::buildAppNamespace('files')
#6 /drone/src/lib/private/legacy/OC_App.php(120): OC_App::registerAutoloading('files', '/drone/src/apps...')
#7 /drone/src/lib/base.php(647): OC_App::loadApps(Array)
#8 /drone/src/lib/base.php(1093): OC::init()
#9 /drone/src/console.php(49): require_once('/drone/src/lib/...')
#10 /drone/src/occ(11): require_once('/drone/src/cons...')

@rullzer rullzer merged commit 6ff0d24 into stable19 Dec 3, 2020
@rullzer rullzer deleted the backport/24519/stable19 branch December 3, 2020 08:37
@rullzer rullzer mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants