Skip to content

[stable18] Remember me is not an app_password #24565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 2 commits into from
Dec 7, 2020
Merged

[stable18] Remember me is not an app_password #24565

rullzer merged 2 commits into from
Dec 7, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Dec 4, 2020

backport of #24552

rullzer and others added 2 commits December 4, 2020 15:57
@rullzer @backportbot
Remember me is not an app_password
7dbb6ea 
While technically they are stored the same. This session variable is
used to indicate that a user is using an app password to authenticate.
Like from a client. Or when having it generated automatically.

Signed-off-by: Roeland Jago Douma <[email protected]>
@MorrisJobke @backportbot
Fix typo
29ee385 
Signed-off-by: Morris Jobke <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.12 milestone Dec 4, 2020
@faily-bot
Copy link

faily-bot bot commented Dec 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 217: failure

handlebars

sqlite

Show full log 
There was 1 error:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testRecipientDeleteInShare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:142
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@rullzer rullzer mentioned this pull request Dec 7, 2020
Merged
@rullzer rullzer merged commit 4ec5b3a into stable18 Dec 7, 2020
@rullzer rullzer deleted the backport/24552/stable18 branch December 7, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

Nextcloud 18.0.12

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @ChristophWurst @MorrisJobke