[stable10] Make sure we don't scan files that can not be accessed #2465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @butonic and @schiessle to be potential reviewers. |
nickvergessen
force-pushed
the
backport-1972-invalid-files-from-scanner
branch
from
fc7c611 to
454cd37
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
backport-1972-invalid-files-from-scanner
branch
from
454cd37 to
eefd458
Compare
MorrisJobke
reviewed
Dec 2, 2016
lib/private/Files/Cache/Scanner.php
Outdated
| */ | ||
| public function scanFile($file, $reuseExisting = 0, $parentId = -1, $cacheData = null, $lock = true) { | ||
|
|
||
| if (!\OC::$server->getDatabaseConnection()->supports4ByteText()) { |
Member
There was a problem hiding this comment.
Error: Call to undefined method OC\DB\Connection::supports4ByteText() in
🙈
MorrisJobke
reviewed
Dec 2, 2016
| | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15 | ||
| | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 | ||
| )%xs', $file)) { | ||
| // 4-byte characters are not supported in file names |
Member
There was a problem hiding this comment.
But this is only the case for mysql, right?
Member
Author
There was a problem hiding this comment.
Not really, because this is also what the view checks:
server/lib/private/Files/View.php
Lines 1809 to 1816 in 072794d
Member
|
Tested and works 👍 |
Member
|
LGTM |
This was referenced Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1972
Let's only backport the first simple commit, without the new classes etc.
@icewind1991 @MorrisJobke