Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 28, 2020

This makes sure we pass .well-known paths to index.php if they are not acme-challenge|pki-validation. The fallback for random files starting with "." is still preserved. Otherwise the rewrite to a 404 status page will cause issues with the get parameters not being preserved when the 404 is handled by our own ErrorDocument handling in

$content .= "\nErrorDocument 404 " . $webRoot . '/';

Ref #24702

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Dec 28, 2020
@LukasReschke LukasReschke changed the title Make sure we properly ass well-known paths to index.php Make sure we properly pass well-known paths to index.php Dec 28, 2020
@rullzer rullzer changed the title Make sure we properly pass well-known paths to index.php Make sure we properly ass well-known paths to index.php Dec 29, 2020
@juliusknorr juliusknorr force-pushed the bugfix/noid/well-known-htaccess branch from 1de612c to 98198e0 Compare December 29, 2020 10:31
@ChristophWurst
Copy link
Member

@daita please test with your setups :)

@ArtificialOwl
Copy link
Member

green test on:

  • local
  • frontal with default setup
  • frontal with htaccess.RewriteBase

👍

@faily-bot
Copy link

faily-bot bot commented Dec 29, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 790: failure

jsunit

Show full log

@ArtificialOwl
Copy link
Member

Not really important as there is a work around, but ...

Did some more test with nextcloud in a sub folder/path: https://example.net:8081/nextcloud/

With default setup, I just need (in apache config) to redirect the request from /.well-known/webfinger to /nextcloud/index.php/.well-known/webfinger. However, request/redirection on /nextcloud/.well-known/webfinger/ returns raw 404.

Now, with htaccess.RewriteBase set to '/nextcloud/ redirection still needs to be done using /nextcloud/index.php/.well-known/webfinger as request/redirection on /nextcloud/.well-known/webfinger/ have their $_GET empty ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants