Skip to content

[stable20] Set the JSCombiner cache if needed #24997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Jan 7, 2021
Merged

[stable20] Set the JSCombiner cache if needed #24997

rullzer merged 1 commit into from
Jan 7, 2021

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 7, 2021

backport of #24988

@rullzer @backportbot
Set the JSCombiner cache if needed
82fab4d 
Found while debugging a customer setup. They had to flush their Redis.
Hence the info was no longer there. Since they also used S3 this meant
requesting the files over and over on template render. Which on S3 is
not cheap.

Now we just write it back if we can't get it from the cache in the first
place. So that the next run has it cached properly again.

Signed-off-by: Roeland Jago Douma <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.5 milestone Jan 7, 2021
@rullzer rullzer added the 3. to review Waiting for reviews label Jan 7, 2021
@rullzer rullzer mentioned this pull request Jan 7, 2021
Merged
1 task
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2021
@faily-bot
Copy link

faily-bot bot commented Jan 7, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1049: failure

sqlite

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\UpdaterLegacyTest::testWrite
Failed asserting that 1610006514 is equal to 1610006515 or is greater than 1610006515.

/drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:118

mysql8.0-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files\Tests\Service\TagServiceTest::testUpdateFileTags
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
+    0 => 3363
 )

/drone/src/apps/files/tests/Service/TagServiceTest.php:152

@rullzer rullzer merged commit 2fa3f24 into stable20 Jan 7, 2021
@rullzer rullzer deleted the backport/24988/stable20 branch January 7, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish performance 🚀

Projects

None yet

Milestone

Nextcloud 20.0.5

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @MorrisJobke @juliusknorr