Skip to content

Update psalm baseline to remove obsolete stuff #25087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Jan 12, 2021
Merged

Update psalm baseline to remove obsolete stuff #25087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a8f15e
Update psalm baseline to remove obsolete stuff
PVince81 Jan 12, 2021
eeac11a
Fix casing of MySQLPlatform class name
PVince81 Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/settings/lib/SetupChecks/SupportedDatabase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
use Doctrine\DBAL\Platforms\MariaDb1027Platform;
use Doctrine\DBAL\Platforms\MySQL57Platform;
use Doctrine\DBAL\Platforms\MySQL80Platform;
use Doctrine\DBAL\Platforms\MySqlPlatform;
use Doctrine\DBAL\Platforms\MySQLPlatform;
use Doctrine\DBAL\Platforms\OraclePlatform;
use Doctrine\DBAL\Platforms\PostgreSQL100Platform;
use Doctrine\DBAL\Platforms\PostgreSQL94Platform;
Expand Down Expand Up @@ -61,7 +61,7 @@ public function check() {
case MySQL80Platform::class: # extends MySQL57Platform
case MySQL57Platform::class: # extends MySQLPlatform
case MariaDb1027Platform::class: # extends MySQLPlatform
case MySqlPlatform::class:
case MySQLPlatform::class:
$result = $this->connection->prepare('SHOW VARIABLES LIKE "version";');
$result->execute();
$row = $result->fetch();
Expand Down
8 changes: 0 additions & 8 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3038,9 +3038,6 @@
<InvalidArrayOffset occurrences="1">
<code>$action['url-postfix']</code>
</InvalidArrayOffset>
<RedundantCondition occurrences="1">
<code>strtolower</code>
</RedundantCondition>
</file>
<file src="lib/private/AppFramework/Services/AppConfig.php">
<MoreSpecificImplementedParamType occurrences="1">
Expand Down Expand Up @@ -5035,11 +5032,6 @@
<code>$this-&gt;appendIfExist($this-&gt;serverroot, 'core/'.$script.'.js')</code>
</InvalidOperand>
</file>
<file src="lib/private/Template/SCSSCacher.php">
<InvalidScalarArgument occurrences="1">
<code>Compiler::LINE_COMMENTS</code>
</InvalidScalarArgument>
</file>
<file src="lib/private/TemplateLayout.php">
<InvalidParamDefault occurrences="2">
<code>string</code>
Expand Down