Skip to content

[stable20] dont offer to edit external config settings if we can't edit them #25132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 4 commits into from
Feb 18, 2021
Merged

[stable20] dont offer to edit external config settings if we can't edit them #25132

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0d85ed
dont offer to edit external config settings if we can't edit them
icewind1991 Dec 11, 2020
6404627
adjust tests
icewind1991 Jan 8, 2021
590ef22
Update apps/files_external/js/statusmanager.js
icewind1991 Jan 19, 2021
e7805e5
fix test
icewind1991 Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update apps/files_external/js/statusmanager.js 
Co-authored-by: Morris Jobke <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991 @MorrisJobke
icewind1991 and MorrisJobke committed Feb 18, 2021
commit 590ef229354893fa1de92f13d5440218b01b1177
2 changes: 1 addition & 1 deletion apps/files_external/js/statusmanager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ OCA.Files_External.StatusManager = {
}
});
} else {
OC.dialogs.info(t('files_external', 'There was an error with message: ') + mountData.error + '. Please contact your system administrator.', t('files_external', 'External mount error'), () => {});
OC.dialogs.info(t('files_external', 'There was an error with message: ') + mountData.error + '. Please contact your system administrator.', t('files_external', 'External mount error'), function(){});
}
} else {
OC.dialogs.confirm(t('files_external', 'There was an error with message: ') + mountData.error + '. Do you want to review mount point config in personal settings page?', t('files_external', 'External mount error'), function (e) {
Expand Down