Skip to content

LDAP: always take the display name from DB, update in the background #25192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blizzz wants to merge 2 commits into from
Closed

LDAP: always take the display name from DB, update in the background #25192

blizzz wants to merge 2 commits into from

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Jan 18, 2021 •
edited
Loading

flanking #25148

blizzz added 2 commits January 18, 2021 22:20
@blizzz
do not serve LDAP displayname from memcache or LDAP but DB
cc00e4a 
- saves potentionally frequent readAttribute requests
- updated now like email in the background

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz
removes dead update code
baa43ef 
both updateEmail and updateQuota are called from processAttributes, so
if values were present they are already known. Thus the code to fetch
them once more is not necessary anymore.

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz added this to the Nextcloud 21 milestone Jan 18, 2021
@faily-bot
Copy link

faily-bot bot commented Jan 18, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1450: failure

sqlite

Show full log 
There were 3 errors:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 140 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:140

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 158 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:158

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotConfigured
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 173 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:173

--

There were 3 warnings:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameWithPlugin
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameFailing
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 12 failures:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToNoneAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

4) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaDefaultProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

5) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaIndividualProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

6) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaNoneProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

7) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

8) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongDefaultQuotaProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

9) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAndDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

10) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayName
Failed asserting that null matches expected 'Roland Deschain'.

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:900

11) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayNamePublicAPI
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Roland Deschain'
+'gunslinger'

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:983

12) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameErrorWithPlugin
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "OC\HintException". Message was: "Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static" at
/drone/src/apps/user_ldap/tests/User_LDAPTest.php:1375
.

mariadb10.1-php7.3

Show full log 
There were 3 errors:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 140 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:140

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 158 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:158

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotConfigured
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 173 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:173

--

There were 3 warnings:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameWithPlugin
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameFailing
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 12 failures:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToNoneAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

4) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaDefaultProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

5) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaIndividualProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

6) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaNoneProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

7) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

8) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongDefaultQuotaProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

9) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAndDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

10) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayName
Failed asserting that null matches expected 'Roland Deschain'.

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:900

11) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayNamePublicAPI
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Roland Deschain'
+'gunslinger'

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:983

12) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameErrorWithPlugin
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "OC\HintException". Message was: "Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static" at
/drone/src/apps/user_ldap/tests/User_LDAPTest.php:1375
.

mariadb10.4-php7.4

Show full log 
There were 3 errors:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 140 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:140

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 158 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:158

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotConfigured
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 173 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:173

--

There were 3 warnings:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameWithPlugin
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameFailing
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 12 failures:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToNoneAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

4) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaDefaultProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

5) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaIndividualProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

6) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaNoneProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

7) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

8) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongDefaultQuotaProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

9) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAndDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

10) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayName
Failed asserting that null matches expected 'Roland Deschain'.

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:900

11) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayNamePublicAPI
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Roland Deschain'
+'gunslinger'

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:983

12) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameErrorWithPlugin
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "OC\HintException". Message was: "Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static" at
/drone/src/apps/user_ldap/tests/User_LDAPTest.php:1375
.

mysql8.0-php7.4

Show full log 
There were 3 errors:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 140 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:140

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 158 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:158

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotConfigured
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 173 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:173

--

There were 3 warnings:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameWithPlugin
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameFailing
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 12 failures:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToNoneAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

4) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaDefaultProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

5) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaIndividualProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

6) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaNoneProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

7) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

8) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongDefaultQuotaProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

9) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAndDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

10) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayName
Failed asserting that null matches expected 'Roland Deschain'.

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:900

11) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayNamePublicAPI
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Roland Deschain'
+'gunslinger'

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:983

12) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameErrorWithPlugin
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "OC\HintException". Message was: "Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static" at
/drone/src/apps/user_ldap/tests/User_LDAPTest.php:1375
.

postgres9.6-php7.3

Show full log 
There were 3 errors:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 140 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:140

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 158 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:158

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotConfigured
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 173 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:173

--

There were 3 warnings:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameWithPlugin
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameFailing
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 12 failures:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToNoneAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

4) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaDefaultProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

5) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaIndividualProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

6) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaNoneProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

7) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

8) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongDefaultQuotaProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

9) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAndDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

10) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayName
Failed asserting that null matches expected 'Roland Deschain'.

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:900

11) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayNamePublicAPI
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Roland Deschain'
+'gunslinger'

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:983

12) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameErrorWithPlugin
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "OC\HintException". Message was: "Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static" at
/drone/src/apps/user_ldap/tests/User_LDAPTest.php:1375
.

postgres11-php7.4

Show full log 
There were 3 errors:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 140 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:140

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 158 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:158

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotConfigured
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 173 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:173

--

There were 3 warnings:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameWithPlugin
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameFailing
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 12 failures:

1) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayName
Failed asserting that null matches expected 'Roland Deschain'.

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:900

2) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayNamePublicAPI
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Roland Deschain'
+'gunslinger'

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:983

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameErrorWithPlugin
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "OC\HintException". Message was: "Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static" at
/drone/src/apps/user_ldap/tests/User_LDAPTest.php:1375
.

4) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

5) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

6) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToNoneAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

7) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaDefaultProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

8) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaIndividualProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

9) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaNoneProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

10) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

11) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongDefaultQuotaProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

12) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAndDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

postgres12-php7.4

Show full log 
There were 3 errors:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 140 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:140

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 158 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:158

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotConfigured
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 173 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:173

--

There were 3 warnings:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameWithPlugin
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameFailing
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 12 failures:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToNoneAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

4) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaDefaultProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

5) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaIndividualProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

6) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaNoneProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

7) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

8) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongDefaultQuotaProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

9) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAndDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

10) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayName
Failed asserting that null matches expected 'Roland Deschain'.

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:900

11) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayNamePublicAPI
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Roland Deschain'
+'gunslinger'

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:983

12) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameErrorWithPlugin
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "OC\HintException". Message was: "Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static" at
/drone/src/apps/user_ldap/tests/User_LDAPTest.php:1375
.

postgres13-php7.4

Show full log 
There were 3 errors:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 140 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:140

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotProvided
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 158 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:158

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateEmailNotConfigured
ArgumentCountError: Too few arguments to function OCA\User_LDAP\User\User::updateEmail(), 0 passed in /drone/src/apps/user_ldap/tests/User/UserTest.php on line 173 and exactly 1 expected

/drone/src/apps/user_ldap/lib/User/User.php:434
/drone/src/apps/user_ldap/tests/User/UserTest.php:173

--

There were 3 warnings:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameWithPlugin
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameFailing
Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 12 failures:

1) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaToNoneAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

4) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaDefaultProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

5) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaIndividualProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

6) OCA\User_LDAP\Tests\User\UserTest::testUpdateQuotaNoneProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

7) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

8) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongDefaultQuotaProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

9) OCA\User_LDAP\Tests\User\UserTest::testUpdateWrongQuotaAndDefaultAllProvided
Expectation failed for method name is "readAttribute" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

10) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayName
Failed asserting that null matches expected 'Roland Deschain'.

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:900

11) OCA\User_LDAP\Tests\User_LDAPTest::testGetDisplayNamePublicAPI
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Roland Deschain'
+'gunslinger'

/drone/src/apps/user_ldap/tests/User_LDAPTest.php:983

12) OCA\User_LDAP\Tests\User_LDAPTest::testSetDisplayNameErrorWithPlugin
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "OC\HintException". Message was: "Trying to configure method "cacheUserDisplayName" which cannot be configured because it does not exist, has not been specified, is final, or is static" at
/drone/src/apps/user_ldap/tests/User_LDAPTest.php:1375
.

This was referenced Jan 19, 2021
Merged
Merged
@rullzer rullzer mentioned this pull request Jan 29, 2021
Merged
@blizzz blizzz modified the milestones: Nextcloud 21, Nextcloud 22 Jan 29, 2021
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 15, 2021

Is there a way to move this forward?

This was referenced May 20, 2021
Merged
Merged
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jun 2, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
This was referenced Apr 7, 2022
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz
Copy link
Member Author

blizzz commented Mar 7, 2023

closing for now

@blizzz blizzz closed this Mar 7, 2023
@blizzz blizzz removed this from the Nextcloud 26 milestone Mar 7, 2023
@MorrisJobke MorrisJobke deleted the enh/noid/ldap-lazy-displayname branch March 7, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developing Work in progress feature: ldap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz @MorrisJobke @skjnldsv