[stable20] Update 3rdparty after Archive_Tar

[nickvergessen]

Signed-off-by: Joas Schilling [email protected]

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1473: failure

acceptance-users

• tests/acceptance/features/users.feature:47

Show full log

  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

[mtierltd]

Hi

This change breaks installing some applications due to the changes in Archive_Tar,
if there are symlinks present in the archive, because extract() will return false.

[ChristophWurst]

Mind elaborating what kind of applications you are talking about? Nextcloud apps? Why would they have symlinks? Do you have any tickets?

[mtierltd]

A nextcloud application yes that has a symlink in the vendor directory, which was not a problem before.
This can be removed from the tarball, so no problem there, but I can tell you that the behavior of Archive_TAR
has changed and now extract() returns false on perfectly fine tarballs, breaking nextcloud application installation with Error: Could not extract app. (timetracker in this case).

We have been having issues after updating to 20.0.6 and I've done a test with Archive_Tar 1.4.12 which
is included in 20.0.6 and it indeed returns false on extract, however Archive_Tar 1.4.11 and earlier versions
return true.

[ChristophWurst]

timetracker

Please let the authors of that apps know that they are not supposed to put symlinks into their tarballs.

[ChristophWurst]

It's already known as per mtierltd/timetracker#86 and mtierltd/timetracker#90

[mtierltd]

Can you elaborate on why symlinks are not to be used? What is the technical reason behind it?

[ChristophWurst]

See the 3rdparty bump nextcloud/3rdparty#603 for details

[mtierltd]

Okay so no technical reason. Thanks.