Skip to content

Use RFC-compliant URL encoding for cookies #25302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Jan 29, 2021
Merged

Use RFC-compliant URL encoding for cookies #25302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use RFC-compliant URL encoding for cookies 
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.

Fixes #24438

Signed-off-by: Marco Ziech <[email protected]>
  • Loading branch information
@mziech
mziech authored Jan 24, 2021
commit 4923c6be2537ff4c1fc4d4c9720cc65945854845
2 changes: 1 addition & 1 deletion lib/private/Http/CookieHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public static function setCookie(string $name,
$header = sprintf(
'Set-Cookie: %s=%s',
$name,
urlencode($value)
rawurlencode($value)
);

if ($path !== '') {
Expand Down