do not lower case search provider names on web ui #25312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
Member
Author
|
/backport to stable20 |
Member
|
you didn't build production, right? |
ChristophWurst
approved these changes
Jan 25, 2021
Member
Author
oops |
Member
Author
|
/compile amend /core/ |
Signed-off-by: Arthur Schiwon <[email protected]> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix/25282/delowercase
branch
from
ce66dc3 to
10f3033
Compare
rullzer
approved these changes
Jan 27, 2021
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Fine by me but I think this was there for a reason
|
The backport to stable20 failed. Please do this backport manually. |
Member
It was there to be correct in English. The current way this string is build is just not conforming with our translation system. But due to the lack of other ideas... (So it actually comes from the rule that in English we uppercase the first word always, because 'Talk', 'Files', and the other search provider names should actually not be uppercase to begin with.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25282