Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #25313

Fixes parent folder that becomes inaccessible when it contains a
non-existing / broken entry because the quota check made the PROPFIND
on parent fail altogether.

Signed-off-by: Vincent Petry <[email protected]>
@faily-bot
Copy link

faily-bot bot commented Jan 25, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1662: failure

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:23
Show full log
  Scenario: share a file with another user that needs to accept shares        # /drone/src/tests/acceptance/features/app-files-sharing.feature:23
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I visit the settings page                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section                                          # AppNavigationContext::iOpenTheSection()
    And I disable accepting the shares by default                             # SettingsContext::iDisableAcceptingTheSharesByDefault()
    And I see that shares are not accepted by default                         # SettingsContext::iSeeThatSharesAreNotAcceptedByDefault()
    And I act as John                                                         # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                              # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I share "farewell.txt" with "user0"                                  # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    And I see that the file list does not contain a file named "farewell.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
    And I accept the share for "/farewell.txt" in the notifications           # NotificationsContext::iAcceptTheShareForInTheNotifications()
      Notifications button in the header could not be found after 100 seconds (NoSuchElementException)
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "farewell.txt"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "farewell.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

@rullzer rullzer merged commit 7ecb8d1 into stable20 Jan 25, 2021
@rullzer rullzer deleted the backport/25313/stable20 branch January 25, 2021 19:44
@rullzer rullzer mentioned this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants