Skip to content

Fix removing remote shares when the remote server is unreachable #25332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 6 commits into from
Nov 5, 2021
Merged

Fix removing remote shares when the remote server is unreachable #25332

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66b5a2d
Add integration tests for deleting federated shares
danxuliu Jan 22, 2021
9497a7c
Add integration tests for listing federated shares
danxuliu Apr 8, 2021
51317a8
Add integration tests for federated shares from unavailable servers
danxuliu Jan 22, 2021
db29fd2
Return false in hasUpdated when storage is not available
PVince81 Oct 21, 2021
c687592
Update psalm baseline
PVince81 Oct 22, 2021
93fb33d
Update lib/private/Files/Storage/Wrapper/Availability.php add void
PVince81 Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update lib/private/Files/Storage/Wrapper/Availability.php add void 
Signed-off-by: Vincent Petry <[email protected]>

Co-authored-by: Carl Schwan <[email protected]>
  • Loading branch information
@PVince81 @CarlSchwan
PVince81 and CarlSchwan authored Nov 5, 2021
commit 93fb33d863413f001e25e6f327b808aea5beab85
2 changes: 1 addition & 1 deletion lib/private/Files/Storage/Wrapper/Availability.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ public function getMetaData($path) {
/**
* @throws StorageNotAvailableException
*/
protected function setUnavailable(?StorageNotAvailableException $e) {
protected function setUnavailable(?StorageNotAvailableException $e): void {
$delay = self::RECHECK_TTL_SEC;
if ($e instanceof StorageAuthException) {
$delay = max(
Expand Down