Skip to content

Improve mention matches #25378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 4 commits into from
Feb 11, 2021
Merged

Improve mention matches #25378

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1344c61
Improve mention matches
nickvergessen Jan 29, 2021
ef7ed47
Make Psalm happy
nickvergessen Jan 29, 2021
86109f7
Fix unit tests
nickvergessen Jan 29, 2021
9803242
Fix linter
nickvergessen Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix linter 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @rullzer
nickvergessen authored and rullzer committed Feb 6, 2021
commit 98032425b4c57e1d39d46c23f02e7ac55d5badd1
2 changes: 1 addition & 1 deletion lib/private/Comments/Comment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public function getMentions() {
return [];
}
$uids = array_unique($mentions[0]);
usort($uids, static function($uid1, $uid2) {
usort($uids, static function ($uid1, $uid2) {
return mb_strlen($uid2) <=> mb_strlen($uid1);
});
$result = [];
Expand Down