Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #25302

PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.

Fixes #24438

Signed-off-by: Marco Ziech <[email protected]>
@faily-bot
Copy link

faily-bot bot commented Jan 29, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1810: failure

mysql8.0-php7.2

Show full log
There were 5 warnings:

1) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParameterTooLarge
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

2) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParametersTooMany
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

3) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

4) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

5) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

--

There was 1 failure:

1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testSearch with data set "check if duplicates are handled correctly" ('John', array('FN', 'CLOUD'), array(), array(array('uri0', 'John Doe'), array('uri1', 'John M. Doe')))
Failed asserting that 1 is identical to 2.

/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:741

@rullzer rullzer mentioned this pull request Feb 5, 2021
@rullzer rullzer added the 3. to review Waiting for reviews label Feb 9, 2021
@rullzer rullzer merged commit 68fa9a4 into stable19 Feb 9, 2021
@rullzer rullzer deleted the backport/25302/stable19 branch February 9, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants