Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #25424

@juliusknorr
Copy link
Member

Hm, wondering why the tests that fail here are not failing on master/stable20:


There were 2 failures:

1) Tests\Core\Controller\LoginControllerTest::testLoginWithInvalidCredentials
Expectation failed for method name is "linkToRoute" when invoked 1 time(s)
Parameter 1 for invocation OCP\IURLGenerator::linkToRoute('core.login.showLoginForm', Array (...)): string does not match expected value.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'user' => 'MyUserName'
     'redirect_url' => '/apps/files'
+    'direct' => 1
 )

/drone/src/core/Controller/LoginController.php:345
/drone/src/core/Controller/LoginController.php:316
/drone/src/tests/Core/Controller/LoginControllerTest.php:448

2) Tests\Core\Controller\LoginControllerTest::testToNotLeakLoginName
Expectation failed for method name is "linkToRoute" when invoked 1 time(s)
Parameter 1 for invocation OCP\IURLGenerator::linkToRoute('core.login.showLoginForm', Array (...)): string does not match expected value.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'user' => '[email protected]'
     'redirect_url' => '/apps/files'
+    'direct' => 1
 )

/drone/src/core/Controller/LoginController.php:345
/drone/src/core/Controller/LoginController.php:316
/drone/src/tests/Core/Controller/LoginControllerTest.php:608

@rullzer
Copy link
Member

rullzer commented Feb 2, 2021

Hm, wondering why the tests that fail here are not failing on master/stable20:


There were 2 failures:

1) Tests\Core\Controller\LoginControllerTest::testLoginWithInvalidCredentials
Expectation failed for method name is "linkToRoute" when invoked 1 time(s)
Parameter 1 for invocation OCP\IURLGenerator::linkToRoute('core.login.showLoginForm', Array (...)): string does not match expected value.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'user' => 'MyUserName'
     'redirect_url' => '/apps/files'
+    'direct' => 1
 )

/drone/src/core/Controller/LoginController.php:345
/drone/src/core/Controller/LoginController.php:316
/drone/src/tests/Core/Controller/LoginControllerTest.php:448

2) Tests\Core\Controller\LoginControllerTest::testToNotLeakLoginName
Expectation failed for method name is "linkToRoute" when invoked 1 time(s)
Parameter 1 for invocation OCP\IURLGenerator::linkToRoute('core.login.showLoginForm', Array (...)): string does not match expected value.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'user' => '[email protected]'
     'redirect_url' => '/apps/files'
+    'direct' => 1
 )

/drone/src/core/Controller/LoginController.php:345
/drone/src/core/Controller/LoginController.php:316
/drone/src/tests/Core/Controller/LoginControllerTest.php:608

there was some rewriting

@rullzer rullzer added the 2. developing Work in progress label Feb 2, 2021
@rullzer rullzer mentioned this pull request Feb 5, 2021
@rullzer rullzer force-pushed the backport/25424/stable19 branch from 1880e17 to 9785986 Compare February 9, 2021 20:53
@rullzer rullzer merged commit a05e0c4 into stable19 Feb 10, 2021
@rullzer rullzer deleted the backport/25424/stable19 branch February 10, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants