-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Emit calendar interaction events #25432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit calendar interaction events #25432
Conversation
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
What about when a calendar object is deleted? Do you consider this is not an interaction or is it just not possible to get that event?
I see your point but I'm not sure about how much this makes sense from a user PoV. Deleting an event or removing a share doesn't seems like a real interaction with someone else. Technically this shouldn't be a barrier to add though. 🤷 |
Right. Anyway the delete event is available for other use cases. |
|
Master is Nextcloud 22 now. |
Something like: VObject\Reader::read($calendarData, VObject\Reader::OPTION_FORGIVING);Then something like this:
|
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
fe6a2b6 to
689e2a0
Compare
|
@tcitworld thanks so much! I will do this in a follow-up nevertheless because none of those methods are reusable and I'm not sure if I want to copy the logic or restructure to make it reusable. |
|
/backport to stable21 |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1900: failureintegration-sharing-v1-video-verification
Show full log |
This adds the calendar part of #19075.
As a follow-up I would also like to look into email attendees but for that I need to parse the calendar data and I'm unsure how to do this reliably.