Skip to content

Conversation

@faust64
Copy link
Contributor

@faust64 faust64 commented Feb 5, 2021

as suggested by @kesselb in #25490

@kesselb kesselb added 2. developing Work in progress bug labels Feb 5, 2021
Signed-off-by: Samuel <[email protected]>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense as other user-visible exceptions are translated too

@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 5, 2021
@rullzer rullzer merged commit 6e46124 into nextcloud:master Feb 5, 2021
@welcome
Copy link

welcome bot commented Feb 5, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@rullzer rullzer added this to the Nextcloud 22 milestone Feb 5, 2021
@rullzer
Copy link
Member

rullzer commented Feb 5, 2021

/backport to stable21

@rullzer
Copy link
Member

rullzer commented Feb 5, 2021

/backport to stable20

@rullzer
Copy link
Member

rullzer commented Feb 5, 2021

/backport to stable19

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@faust64 faust64 deleted the fix-sharemanager-genericshareexception branch February 8, 2021 08:58
@MorrisJobke
Copy link
Member

@rullzer Backports failed :/

@rullzer
Copy link
Member

rullzer commented Mar 30, 2021

/backport to stable20

@rullzer
Copy link
Member

rullzer commented Mar 30, 2021

/backport to stable21

@nickvergessen
Copy link
Member

Should we use GenericShareException

@rullzer
Copy link
Member

rullzer commented Mar 30, 2021

Should we use GenericShareException

Yeah might make sense now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants