Skip to content

Deprecate all remaining event constants #25546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Feb 9, 2021
Merged

Deprecate all remaining event constants #25546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/public/App/ManagerEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,24 @@
* @since 9.0.0
*/
class ManagerEvent extends Event {
/**
* @deprecated 22.0.0
*/
public const EVENT_APP_ENABLE = 'OCP\App\IAppManager::enableApp';

/**
* @deprecated 22.0.0
*/
public const EVENT_APP_ENABLE_FOR_GROUPS = 'OCP\App\IAppManager::enableAppForGroups';

/**
* @deprecated 22.0.0
*/
public const EVENT_APP_DISABLE = 'OCP\App\IAppManager::disableApp';

/**
* @since 9.1.0
* @deprecated 22.0.0
*/
public const EVENT_APP_UPDATE = 'OCP\App\IAppManager::updateApp';

Expand Down
5 changes: 5 additions & 0 deletions lib/public/Authentication/TwoFactorAuth/IProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,13 @@ interface IProvider {

/**
* @since 14.0.0
* @deprecated 22.0.0
*/
public const EVENT_SUCCESS = self::class . '::success';

/**
* @deprecated 22.0.0
*/
public const EVENT_FAILED = self::class . '::failed';

/**
Expand Down
7 changes: 7 additions & 0 deletions lib/public/Authentication/TwoFactorAuth/IRegistry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@
* @since 14.0.0
*/
interface IRegistry {
/**
* @deprecated 22.0.0
*/
public const EVENT_PROVIDER_ENABLED = self::class . '::enable';

/**
* @deprecated 22.0.0
*/
public const EVENT_PROVIDER_DISABLED = self::class . '::disable';

/**
Expand Down
3 changes: 3 additions & 0 deletions lib/public/Comments/CommentsEntityEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
* @since 9.1.0
*/
class CommentsEntityEvent extends Event {
/**
* @deprecated 22.0.0
*/
public const EVENT_ENTITY = 'OCP\Comments\ICommentsManager::registerEntity';

/** @var string */
Expand Down
16 changes: 16 additions & 0 deletions lib/public/Comments/CommentsEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,25 @@
* @since 9.0.0
*/
class CommentsEvent extends Event {

/**
* @deprecated 22.0.0
*/
public const EVENT_ADD = 'OCP\Comments\ICommentsManager::addComment';

/**
* @deprecated 22.0.0
*/
public const EVENT_PRE_UPDATE = 'OCP\Comments\ICommentsManager::preUpdateComment';

/**
* @deprecated 22.0.0
*/
public const EVENT_UPDATE = 'OCP\Comments\ICommentsManager::updateComment';

/**
* @deprecated 22.0.0
*/
public const EVENT_DELETE = 'OCP\Comments\ICommentsManager::deleteComment';

/** @var string */
Expand Down
4 changes: 4 additions & 0 deletions lib/public/Console/ConsoleEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
* @since 9.0.0
*/
class ConsoleEvent extends Event {

/**
* @deprecated 22.0.0
*/
public const EVENT_RUN = 'OC\Console\Application::run';

/** @var string */
Expand Down
1 change: 1 addition & 0 deletions lib/public/IPreview.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ interface IPreview {

/**
* @since 9.2.0
* @deprecated 22.0.0
*/
public const EVENT = self::class . ':' . 'PreviewRequested';

Expand Down
12 changes: 12 additions & 0 deletions lib/public/SystemTag/ManagerEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,20 @@
* @since 9.0.0
*/
class ManagerEvent extends Event {

/**
* @deprecated 22.0.0
*/
public const EVENT_CREATE = 'OCP\SystemTag\ISystemTagManager::createTag';

/**
* @deprecated 22.0.0
*/
public const EVENT_UPDATE = 'OCP\SystemTag\ISystemTagManager::updateTag';

/**
* @deprecated 22.0.0
*/
public const EVENT_DELETE = 'OCP\SystemTag\ISystemTagManager::deleteTag';

/** @var string */
Expand Down
8 changes: 8 additions & 0 deletions lib/public/SystemTag/MapperEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,15 @@
* @since 9.0.0
*/
class MapperEvent extends Event {

/**
* @deprecated 22.0.0
*/
public const EVENT_ASSIGN = 'OCP\SystemTag\ISystemTagObjectMapper::assignTags';

/**
* @deprecated 22.0.0
*/
public const EVENT_UNASSIGN = 'OCP\SystemTag\ISystemTagObjectMapper::unassignTags';

/** @var string */
Expand Down
4 changes: 4 additions & 0 deletions lib/public/SystemTag/SystemTagsEntityEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@
* @since 9.1.0
*/
class SystemTagsEntityEvent extends Event {

/**
* @deprecated 22.0.0
*/
public const EVENT_ENTITY = 'OCP\SystemTag\ISystemTagManager::registerEntity';

/** @var string */
Expand Down
10 changes: 9 additions & 1 deletion lib/public/WorkflowEngine/IManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,18 @@ interface IManager {
public const MAX_OPERATION_VALUE_BYTES = 4096;

/**
* @deprecated Will be removed in NC19. Use the dedicated events in OCP\WorkflowEngine\Events
* @deprecated 17.0.0 Will be removed in NC19. Use the dedicated events in OCP\WorkflowEngine\Events
*/
public const EVENT_NAME_REG_OPERATION = 'OCP\WorkflowEngine::registerOperations';

/**
* @deprecated 17.0.0
*/
public const EVENT_NAME_REG_ENTITY = 'OCP\WorkflowEngine::registerEntities';

/**
* @deprecated 17.0.0
*/
public const EVENT_NAME_REG_CHECK = 'OCP\WorkflowEngine::registerChecks';

/**
Expand Down