Do not send imip email to invalid recipients #25582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
This was referenced Feb 11, 2021
rullzer
approved these changes
Feb 11, 2021
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
seems sane. Is it easy to add some tests?
tcitworld
requested changes
Feb 11, 2021
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
Needs tests changes into IMipPluginTest.php.
Member
|
Makes me think we could first check in |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/no-imip-for-invalid-recpient
branch
from
43aaebc to
9430de1
Compare
Member
Author
#25585 :) |
tcitworld
approved these changes
Feb 11, 2021
This was referenced Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just had an error caused by Calendar as I trued to save this vcard:
Details
{ "reqId": "nQnCxyq0HNQqfZZFuxWv", "level": 4, "time": "2021-02-11T12:18:06+00:00", "remoteAddr": "127.0.0.1", "user": "admin", "app": "webdav", "method": "PUT", "url": "/remote.php/dav/calendars/admin/personal/7A27E6FF-0910-46B1-A0CF-429B35126D4D.ics", "message": { "Exception": "TypeError", "Message": "idn_to_ascii() expects parameter 1 to be string, null given", "Code": 0, "Trace": [ { "file": "/home/christoph/workspace/nextcloud/lib/private/Mail/Message.php", "line": 84, "function": "idn_to_ascii", "args": [ "*** sensitive parameter replaced ***", 0, 1 ] }, { "file": "/home/christoph/workspace/nextcloud/lib/private/Mail/Message.php", "line": 149, "function": "convertAddresses", "class": "OC\\Mail\\Message", "type": "->", "args": [ { "": "otheruser" } ] }, { "file": "/home/christoph/workspace/nextcloud/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php", "line": 238, "function": "setTo", "class": "OC\\Mail\\Message", "type": "->", "args": [ { "": "otheruser" } ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php", "line": 89, "function": "schedule", "class": "OCA\\DAV\\CalDAV\\Schedule\\IMipPlugin", "type": "->", "args": [ { "uid": "4d5ce95b-a3b3-48cd-bf3b-1d66d5560f98", "component": "VEVENT", "method": "REQUEST", "sequence": 3, "sender": "mailto:[email protected]", "senderName": { "name": "CN", "noName": false, "parent": null, "__class__": "Sabre\\VObject\\Parameter" }, "recipient": "mailto:", "recipientName": "otheruser", "scheduleStatus": "3.7;Could not find principal.", "message": { "name": "VCALENDAR", "parent": null, "__class__": "Sabre\\VObject\\Component\\VCalendar" }, "significantChange": true, "__class__": "Sabre\\VObject\\ITip\\Message" } ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Schedule/Plugin.php", "line": 350, "function": "emit", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ "schedule", [ { "uid": "4d5ce95b-a3b3-48cd-bf3b-1d66d5560f98", "component": "VEVENT", "method": "REQUEST", "sequence": 3, "sender": "mailto:[email protected]", "senderName": { "name": "CN", "noName": false, "parent": null, "__class__": "Sabre\\VObject\\Parameter" }, "recipient": "mailto:", "recipientName": "otheruser", "scheduleStatus": "3.7;Could not find principal.", "message": { "name": "VCALENDAR", "parent": null, "__class__": "Sabre\\VObject\\Component\\VCalendar" }, "significantChange": true, "__class__": "Sabre\\VObject\\ITip\\Message" } ] ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Schedule/Plugin.php", "line": 626, "function": "deliver", "class": "Sabre\\CalDAV\\Schedule\\Plugin", "type": "->", "args": [ { "uid": "4d5ce95b-a3b3-48cd-bf3b-1d66d5560f98", "component": "VEVENT", "method": "REQUEST", "sequence": 3, "sender": "mailto:[email protected]", "senderName": { "name": "CN", "noName": false, "parent": null, "__class__": "Sabre\\VObject\\Parameter" }, "recipient": "mailto:", "recipientName": "otheruser", "scheduleStatus": "3.7;Could not find principal.", "message": { "name": "VCALENDAR", "parent": null, "__class__": "Sabre\\VObject\\Component\\VCalendar" }, "significantChange": true, "__class__": "Sabre\\VObject\\ITip\\Message" } ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Schedule/Plugin.php", "line": 337, "function": "processICalendarChange", "class": "Sabre\\CalDAV\\Schedule\\Plugin", "type": "->", "args": [ { "name": "VCALENDAR", "parent": null, "__class__": "Sabre\\VObject\\Component\\VCalendar" }, { "name": "VCALENDAR", "parent": null, "__class__": "Sabre\\VObject\\Component\\VCalendar" }, [ "mailto:[email protected]", "/remote.php/dav/principals/users/admin/" ], [], true ] }, { "file": "/home/christoph/workspace/nextcloud/apps/dav/lib/CalDAV/Schedule/Plugin.php", "line": 150, "function": "calendarObjectChange", "class": "Sabre\\CalDAV\\Schedule\\Plugin", "type": "->", "args": [ { "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" }, { "name": "VCALENDAR", "parent": null, "__class__": "Sabre\\VObject\\Component\\VCalendar" }, "calendars/admin/personal", true, false ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php", "line": 89, "function": "calendarObjectChange", "class": "OCA\\DAV\\CalDAV\\Schedule\\Plugin", "type": "->", "args": [ { "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" }, { "name": "VCALENDAR", "parent": null, "__class__": "Sabre\\VObject\\Component\\VCalendar" }, "calendars/admin/personal", true, false ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Plugin.php", "line": 897, "function": "emit", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ "calendarObjectChange", [ { "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" }, { "name": "VCALENDAR", "parent": null, "__class__": "Sabre\\VObject\\Component\\VCalendar" }, "calendars/admin/personal", true, false ] ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Plugin.php", "line": 739, "function": "validateICalendar", "class": "Sabre\\CalDAV\\Plugin", "type": "->", "args": [ "*** sensitive parameter replaced ***", "*** sensitive parameter replaced ***", false, { "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" }, false ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php", "line": 89, "function": "beforeWriteContent", "class": "Sabre\\CalDAV\\Plugin", "type": "->", "args": [ "*** sensitive parameter replaced ***", { "__class__": "OCA\\DAV\\CalDAV\\CalendarObject" }, "*** sensitive parameter replaced ***", false ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 1133, "function": "emit", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ "beforeWriteContent", [ "*** sensitive parameter replaced ***", { "__class__": "OCA\\DAV\\CalDAV\\CalendarObject" }, "*** sensitive parameter replaced ***", false ] ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php", "line": 492, "function": "updateFile", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php", "line": 89, "function": "httpPut", "class": "Sabre\\DAV\\CorePlugin", "type": "->", "args": [ { "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" } ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 472, "function": "emit", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ "method:PUT", [ { "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" } ] ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 253, "function": "invokeMethod", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ { "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" } ] }, { "file": "/home/christoph/workspace/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 321, "function": "start", "class": "Sabre\\DAV\\Server", "type": "->", "args": [] }, { "file": "/home/christoph/workspace/nextcloud/apps/dav/lib/Server.php", "line": 332, "function": "exec", "class": "Sabre\\DAV\\Server", "type": "->", "args": [] }, { "file": "/home/christoph/workspace/nextcloud/apps/dav/appinfo/v2/remote.php", "line": 35, "function": "exec", "class": "OCA\\DAV\\Server", "type": "->", "args": [] }, { "file": "/home/christoph/workspace/nextcloud/remote.php", "line": 167, "args": [ "/home/christoph/workspace/nextcloud/apps/dav/appinfo/v2/remote.php" ], "function": "require_once" } ], "File": "/home/christoph/workspace/nextcloud/lib/private/Mail/Message.php", "Line": 84, "CustomMessage": "--" }, "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0", "version": "22.0.0.0" }This smells very related to #25310.
Fixes #18941 #15243