Skip to content

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 15, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #25594

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.10 milestone Feb 15, 2021
@rullzer rullzer added the 3. to review Waiting for reviews label Feb 15, 2021
@rullzer
Copy link
Member

rullzer commented Feb 15, 2021

/compile amend /

1 similar comment
@rullzer
Copy link
Member

rullzer commented Feb 17, 2021

/compile amend /

@rullzer rullzer mentioned this pull request Feb 17, 2021
Some NC installations may use a LDAP UUID for the username. If that
is the case, then the tooltip for who a file/folder was shared by may say something
like `Shared with Steve McQueen ([email protected]) by FKDJ39-38D794JG-4398GJODF9H3G-4534`.

This commit changes the value showed for the owner to the full display name.

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@faily-bot
Copy link

faily-bot bot commented Feb 17, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2352: failure

mariadb10.4-php7.3

Show full log
There were 5 warnings:

1) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParameterTooLarge
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

2) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParametersTooMany
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

3) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

4) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

5) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testDeleteUser with data set #5 (1, 'a', 'b', 'c', 'b', false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2272

mysql8.0-php7.2

@rullzer rullzer merged commit 733311d into stable19 Feb 17, 2021
@rullzer rullzer deleted the backport/25594/stable19 branch February 17, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants