Skip to content

Explicitly check hex2bin input #25714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Apr 22, 2021
Merged

Explicitly check hex2bin input #25714

MorrisJobke merged 1 commit into from
Apr 22, 2021

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Feb 18, 2021

For #23197

Signed-off-by: Roeland Jago Douma [email protected]

@rullzer
Explicitly check hex2bin input
16652ac 
For #23197

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added the 2. developing Work in progress label Feb 18, 2021
@rullzer rullzer added this to the Nextcloud 22 milestone Feb 18, 2021
@AndyXheli
Copy link
Contributor

AndyXheli commented Feb 25, 2021

@rullzer any updates on this? Still have the issue on NC 20.0.8

@rullzer
Copy link
Member Author

rullzer commented Mar 1, 2021

@rullzer any updates on this? Still have the issue on NC 20.0.8

And this patchis not helping? Any different error?

@AndyXheli
Copy link
Contributor

AndyXheli commented Mar 1, 2021 •
edited
Loading

@rullzer Testing it out but so far so good. I'll keep you posted. Question, dose this patch have to be added manual every time a new Nextcloud version comes out or will it be added to the next version ?

@AndyXheli
Copy link
Contributor

AndyXheli commented Mar 11, 2021

@rullzer so far so good. Do you know if this will be pushed on the next nextcloud release?

@pseguret
Copy link

pseguret commented Apr 13, 2021

@rullzer any updates on this? Still have the issue on NC 20.0.8

And this patchis not helping? Any different error?

@rullzer does this patch can be applied to NC 20.0.9 ? Thx

@AndyXheli AndyXheli mentioned this pull request Apr 21, 2021
Closed
@rullzer
Copy link
Member Author

rullzer commented Apr 22, 2021

Hi sorry I was busy debyugging this with others still.
It seems to indeed to the trick let me make sure it gets in.

MorrisJobke
MorrisJobke approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke MorrisJobke merged commit 393309b into master Apr 22, 2021
@MorrisJobke MorrisJobke deleted the fix/23197/explicitly_check_hex2bin_input branch April 22, 2021 11:23
@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 22, 2021

/backport to stable21

@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 22, 2021

/backport to stable20

This was referenced Apr 22, 2021
Merged
Merged
@AndyXheli
Copy link
Contributor

AndyXheli commented Apr 22, 2021

Hi sorry I was busy debyugging this with others still.

It seems to indeed to the trick let me make sure it gets in.

No problem at all thank you so much for you time. It's really appreciated. Thank you again. 🙏🏻🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

+1 more reviewer

@AndyXheli AndyXheli AndyXheli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2. developing Work in progress

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

6 participants

@rullzer @AndyXheli @pseguret @MorrisJobke @ChristophWurst