Skip to content

ShareesAPIController should respect groups disallowed from sharing #25744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tetrachloromethane250 wants to merge 7 commits into from
Closed

ShareesAPIController should respect groups disallowed from sharing #25744

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ce0aa8e
Add check that user is allowed to share
Tetrachloroethene Feb 22, 2021
56cc408
Match create parameters
Tetrachloroethene Feb 22, 2021
be8bd42
Match create parameters for all instances
Tetrachloroethene Feb 22, 2021
d8396ef
Apply suggestions from code review
Tetrachloromethane250 Mar 1, 2021
e40590c
Add last change from review
Tetrachloromethane250 Mar 1, 2021
ded214e
Fix existing tests
Tetrachloroethene Mar 1, 2021
5550611
Merge branch 'master' into fix/20950/Transfer-Ownership-Ignores-Shari…
skjnldsv Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix existing tests 
Signed-off-by: Daniel Bishop <[email protected]>
  • Loading branch information
@Tetrachloroethene
Tetrachloroethene committed Mar 1, 2021
commit ded214ecce1a4d0ffb6ce88f03e3f3e90386910b
12 changes: 8 additions & 4 deletions apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,11 @@ public function testSearch($getData, $apiSetting, $enumSetting, $remoteSharingEn
/** @var IConfig|\PHPUnit\Framework\MockObject\MockObject $config */
$config = $this->createMock(IConfig::class);

// TODO: Add exclude groups config request
$config->expects($this->exactly(1))
$config->expects($this->exactly(2))
->method('getAppValue')
->with($this->anything(), $this->anything(), $this->anything())
->willReturnMap([
['core', 'shareapi_exclude_groups', 'no', 'no'],
['files_sharing', 'lookupServerEnabled', 'yes', 'yes'],
]);

Expand Down Expand Up @@ -360,8 +360,12 @@ public function testSearchInvalid($getData, $message) {

/** @var IConfig|\PHPUnit\Framework\MockObject\MockObject $config */
$config = $this->createMock(IConfig::class);
$config->expects($this->never())
->method('getAppValue');
$config->expects($this->exactly(1))
->method('getAppValue')
->with($this->anything(), $this->anything(), $this->anything())
->willReturnMap([
['core', 'shareapi_exclude_groups', 'no', 'no'],
]);

/** @var string */
$uid = 'test123';
Expand Down