Use mimetype from cache for workflow checks #25768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
workflow-use-cache-for-mimetype
branch
from
264c449 to
de77189
Compare
rullzer
approved these changes
Mar 4, 2021
nickvergessen
requested review from
blizzz
and removed request for
nickvergessen
Member
That renders the check fairly useless when working with non-local files, doesn't it? |
Member
Author
|
I'm unsure about having the content-based detection in the first place, having the filecache and workflow both use different sources of mimetypes is bound to lead to confusion |
Member
|
CI is unhappy |
skjnldsv
added
2. developing
Merged
Member
|
/rebase |
nextcloud-command
force-pushed
the
workflow-use-cache-for-mimetype
branch
from
de77189 to
919e256
Compare
Merged
Merged
Merged
Merged
Signed-off-by: Robin Appelman <[email protected]>
the method is only called if the file exists already a check against storing the fallback mimetype is added as a safety instead Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
PVince81
force-pushed
the
workflow-use-cache-for-mimetype
branch
from
919e256 to
cb4648d
Compare
Member
|
rebased and conflict solved |
PVince81
approved these changes
Dec 20, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍
I wasn't able to run into such situation myself with minio as primary object store, however I sent this to someone having issues with flow and mime types and can confirm that this fixed the problem. Let's ship this!
Member
|
/backport to stable25 |
Member
|
/backport to stable24 |
This was referenced Dec 20, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file_existscheckMotivation is that when using object stores, the file is added to the cache (and thus triggering workflow hooks) before it's written to the storage.