Do not attempt to read 0 bytes when manually iterating over a non-seekable file #25804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/fread-0
branch
from
4faadc0 to
19eb48b
Compare
ChristophWurst
approved these changes
Feb 26, 2021
rullzer
approved these changes
Mar 1, 2021
Member
|
@juliushaertl @rullzer @ChristophWurst Backport to at least stable21? |
Member
|
/backport to stable21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that when fseek fails and we iterate over a file with fread in order to get to the requested chunk, the manual seek doesn't error by trying to read 0 bytes when the expected from position is reached.
Should fix occurences of:
fread(): Length parameter must be greater than 0 at /var/www/nextcloud/lib/private/Files/View.php#460