Skip to content

do not die after LDAP auth failed with expired acc #25860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Mar 2, 2021
Merged

do not die after LDAP auth failed with expired acc #25860

blizzz merged 1 commit into from
Mar 2, 2021
+6 −3

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Mar 1, 2021

  • some servers return error code 53

@blizzz
do not die after LDAP auth failed with expired acc
5ad08c7 
- some servers return error code 53

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz added this to the Nextcloud 22 milestone Mar 1, 2021
tofuSCHNITZEL
tofuSCHNITZEL reviewed Mar 1, 2021
View reviewed changes
Copy link
Contributor

@tofuSCHNITZEL tofuSCHNITZEL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tofuSCHNITZEL
tofuSCHNITZEL approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@tofuSCHNITZEL tofuSCHNITZEL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blizzz blizzz merged commit ef53896 into master Mar 2, 2021
@blizzz blizzz deleted the fix/noid/ldap-bind-expired branch March 2, 2021 20:34
@blizzz
Copy link
Member Author

blizzz commented Mar 2, 2021

/backport to stable21

@blizzz
Copy link
Member Author

blizzz commented Mar 2, 2021

/backport to stable20

@blizzz
Copy link
Member Author

blizzz commented Mar 2, 2021

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 2, 2021
Merged
This was referenced Mar 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tofuSCHNITZEL tofuSCHNITZEL tofuSCHNITZEL approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: ldap

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz @ChristophWurst @tofuSCHNITZEL