Only clear share password model when actually saved #25911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
requested review from
ChristophWurst,
danxuliu,
juliusknorr,
nickvergessen and
rullzer
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
Member
Author
|
pfff, so compiling with |
Member
Author
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
bugfix/noid/fix-share-password-saving
branch
from
7bbe482 to
3b8a7d6
Compare
rullzer
approved these changes
Mar 3, 2021
Member
Author
|
/compile amend / |
1 similar comment
Member
Author
|
/compile amend / |
Member
Author
|
pfff, why isn't the amend working ? |
Member
Author
|
let me do this manually... |
Instead of always clearing the password in the share model, now only do it when it was actually saved. Fixes an issue where saving another field would clear the password too early and prevent it to be saved when the dropdown closed. Signed-off-by: Vincent Petry <[email protected]> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
PVince81
force-pushed
the
bugfix/noid/fix-share-password-saving
branch
from
3b8a7d6 to
3462444
Compare
ChristophWurst
approved these changes
Mar 11, 2021
This was referenced Mar 11, 2021
Member
you're not alone, let me check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always clearing the password in the share model, now only do
it when it was actually saved.
Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.