Add getID function to the simplefile implementation #26003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it is useful to get the actual fileid Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
ChristophWurst,
MorrisJobke,
icewind1991 and
juliusknorr
juliusknorr
approved these changes
Mar 8, 2021
juliusknorr
requested changes
Mar 8, 2021
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Ah wait, should be added to the public interface as well then I guess 😉
Member
Author
Not for now. I'm not sure yet how to do it with the other implementations. |
ChristophWurst
approved these changes
Mar 11, 2021
MorrisJobke
approved these changes
Mar 15, 2021
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
Contributor
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is useful to get the actual fileid
Signed-off-by: Roeland Jago Douma [email protected]