Return the fileid from copyFromCache and use it instead of doing an extra query
#26013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
Mar 9, 2021
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Didn't test but the code makes sense!
PVince81
approved these changes
Mar 11, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 Looks fine, see comments if applicable
| $folderContent = $sourceCache->getFolderContentsById($sourceEntry->getId()); | ||
| foreach ($folderContent as $subEntry) { | ||
| $subTargetPath = $targetPath . '/' . $subEntry->getName(); | ||
| $this->copyFromCache($sourceCache, $subEntry, $subTargetPath); |
Member
There was a problem hiding this comment.
I guess we're not afraid of very deep folder structures and stack overflows ?
Edit: just saw it's old copied code, but something to keep in mind as tech debt?
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
object-store-copy-cache-id
branch
from
ea09768 to
d7748e2
Compare
Member
|
build restarted... |
PVince81
added
4. to release
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move the existing
copyFromCachecode around and expose it trough the public interface.