Provisioning API to IBootstrap #26029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable21 |
nickvergessen
approved these changes
Mar 9, 2021
8 tasks
rullzer
force-pushed
the
enh/boostrap/provisioning_api
branch
2 times, most recently
from
0f62d58 to
e5b1d59
Compare
Signed-off-by: Roeland Jago Douma <[email protected]>
PVince81
approved these changes
Mar 10, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍
I'm guessing this is to remove the annoying warnings in the logs ?
Assuming that the other things marked by code scanning won't spam the logs.
Member
Author
More so Joas can continue with his code :) |
Member
|
please address the inline psalm reports. they seem all legit :) |
Member
|
Just for the record we need to backport to 21, so only "cleanup" what works there. |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
enh/boostrap/provisioning_api
branch
from
ebcc772 to
a1e5090
Compare
ChristophWurst
approved these changes
Mar 10, 2021
Member
|
Backport worked in #26044 Not sure what the bot was complaining about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma [email protected]