Skip to content

update icewind/smb to 3.4.0 #26046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Mar 21, 2021
Merged

update icewind/smb to 3.4.0 #26046

MorrisJobke merged 1 commit into from
Mar 21, 2021

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Mar 10, 2021

Highlights include

  • More consistent handling of mtime
  • Possible fix for a segfault
  • Add option to configure min/max protocol versions

@icewind1991
update icewind/smb to 3.4.0
66781e7 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 10, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Mar 10, 2021
@icewind1991 icewind1991 requested a review from rullzer March 10, 2021 14:34
rullzer
rullzer approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but sure

@rullzer rullzer requested a review from MorrisJobke March 20, 2021 12:21
MorrisJobke
MorrisJobke approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit 9e9b014 into master Mar 21, 2021
@MorrisJobke MorrisJobke deleted the smb-3.4.0 branch March 21, 2021 20:05
@icewind1991
Copy link
Member Author

icewind1991 commented Mar 23, 2021

/backport to stable21

@icewind1991
Copy link
Member Author

icewind1991 commented Mar 23, 2021

/backport to stable20

This was referenced Mar 23, 2021
Merged
Merged
@icewind1991 icewind1991 mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @rullzer @MorrisJobke