Skip to content

[stable21] Allow autocomplete based on phone sync #26056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 17 commits into from
Mar 11, 2021
Merged

[stable21] Allow autocomplete based on phone sync #26056

rullzer merged 17 commits into from
Mar 11, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 11, 2021

Backport of #26031

@nickvergessen
Add a KnownUsers database with model
ebb9f1d 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Store when a user knows another user based on phone number
3feca65 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Delete matches when a user changes their phone number
19ccc99 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Delete matches when the user is being deleted
5af22f8 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add a service to find out if a user knows another user
88855d8 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add a config setting to restrict autocompletion to phonebook matches
52d43bf 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Restrict autocompletion also based on the phonebook known users
c7560ab 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add integration tests for autocomplete/get (similar to sharees API)
30610aa 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add a hint that the settings are OR based
8069c52 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add a setting to restrict returning a full match unless in phonebook …
77f6d76 
…or same group

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix CS hopefully
5afaf3d 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Change label also in the acceptance tests
72fb176 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Also execute the new tests on drone
49f7d08 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Also clear the knownUser when changing via the settings endpoint
490bfa7 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Bump version to run migration
99c1eda 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Rename some parameters and methods to make the API more clear
5fa52d4 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Clean up the logic of the contacts store a bit
62ef450 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the Nextcloud 21.0.1 milestone Mar 11, 2021
@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 11, 2021

Diff size doesn't match due to the composer update on the autoloader

PVince81
PVince81 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rullzer rullzer merged commit 0e8ada1 into stable21 Mar 11, 2021
@rullzer rullzer deleted the backport/26031/stable21 branch March 11, 2021 08:31
@rullzer rullzer mentioned this pull request Mar 26, 2021
Merged
2 tasks
@rullzer rullzer mentioned this pull request Apr 8, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: settings feature: sharing feature: users and groups

Projects

None yet

Milestone

Nextcloud 21.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @rullzer @PVince81