Log exceptions when creating share #26115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the exceptions don't always contain a useful message for the UI, but also because in some cases we need to find out what went wrong. In some setups, a ShareNotFoundException might happen during creation when we try to re-read the just written share. Usually related to Galera Cluster where node syncing wait is not enabled. Signed-off-by: Vincent Petry <[email protected]>
PVince81
requested review from
ChristophWurst,
juliusknorr,
kesselb and
rullzer
ChristophWurst
approved these changes
Mar 15, 2021
kesselb
approved these changes
Mar 15, 2021
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong and look at a stack trace.
In some setups, a ShareNotFound exception might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.
Without this, nothing is log and it's almost impossible to debug.