Skip to content

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Mar 18, 2021

  • Use Node search api directly from files' search provider, skipping a few deprecated layers
  • Unify handling of node search methods by transforming all search methods into "new" search queries
  • Handle limit, offset and order in node search api (in a somewhat suboptimal way)

@icewind1991 icewind1991 added the 2. developing Work in progress label Mar 18, 2021
@icewind1991 icewind1991 changed the title [wip] search [wip] limit and offset in file search Mar 18, 2021
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 force-pushed the unified-search-node branch from 2fb2d02 to c25f7d7 Compare March 19, 2021 13:54
@icewind1991 icewind1991 force-pushed the unified-search-node branch from c25f7d7 to b38618c Compare March 19, 2021 15:08
@icewind1991 icewind1991 changed the title [wip] limit and offset in file search Handle limit offset and sorting in files search Mar 19, 2021
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 19, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Mar 19, 2021
@icewind1991 icewind1991 requested review from ChristophWurst, MorrisJobke, rullzer and skjnldsv and removed request for ChristophWurst March 19, 2021 15:26
@skjnldsv
Copy link
Member

Thanks for this @icewind1991 !

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and still works 👍

@MorrisJobke MorrisJobke merged commit 1c074e7 into master Mar 22, 2021
@MorrisJobke MorrisJobke deleted the unified-search-node branch March 22, 2021 20:48
@icewind1991
Copy link
Member Author

/backport to stable21

@icewind1991
Copy link
Member Author

/backport to stable20

@icewind1991
Copy link
Member Author

/backport to stable19

@backportbot-nextcloud
Copy link

The backport to stable19 failed. Please do this backport manually.

icewind1991 added a commit that referenced this pull request Apr 1, 2021
rullzer added a commit that referenced this pull request Apr 1, 2021
remove leftover debug @NoCSRFRequired introduced with #26198
backportbot-nextcloud bot pushed a commit that referenced this pull request Apr 1, 2021
backportbot-nextcloud bot pushed a commit that referenced this pull request Apr 1, 2021
MorrisJobke added a commit that referenced this pull request Apr 1, 2021
[stable21] remove leftover debug @NoCSRFRequired introduced with #26198
MorrisJobke added a commit that referenced this pull request Apr 1, 2021
[stable20] remove leftover debug @NoCSRFRequired introduced with #26198
This was referenced Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants