Avatar privacy and new scope

[PVince81]

Todos

• Private avatars are now only shown to their owners.
• Avatar that have not been set to public will only be shown for logged in users.
• New option for "v2-private" but
  • Add option in menu
  • Make sure the option is working in various places
  • Only make the extra option available for "Avatar", "Phone number", "Twitter", "Website", "Address"
  • Scope menu must always be visible even when federation / public servers option is off
  • Remove federated options when lookup server is disabled
  • Unit tests
• extend OCS provisioning endpoint "https://vvortex.local/ocs/v2.php/cloud/users/$userId"
  • allow getting scope values
  • allow setting the scope values
  • allow setting other values like phone, etc (if not already)
  • users can get/set fields and scope values for themselves, but not for other users
  • admin cannot get/set fields for other users
  • Unit tests
• add boolean capability to signal the ability to set scopes

Issues

• Issue? Switching avatar privacy doesn't reset cache for browsers (Chromium doesn't reload avatars on shift+refresh) => inform that it's only about 1 day caching
• It seems the wording of the current options is already confusing, as they are about federated sharing => solved
• Improve performance of placeholder avatar (currently using the uncached guest avatar)
• Phone, address, twitter, website fields need to be always visible and editable (never disabled)
• What icons to use for "Private" and "Local" ?
• Test/check avatar endpoint with mobile clients as they might use the public unauthenticated endpoint and raise tickets accordingly => I was told that they use authentication headers
• Fix AvatarManagerTest

[PVince81]

• BUG: mapping of old values seems to not work

[PVince81]

Updated top post to also extend the OCS API endpoint to allow clients to get/set scope values

[PVince81]

hah... it appears that the provisioning API is also cheating and using AccountManager->getUser(), so the mapping will not work there. I'll migrate it to use IAccountManager->getAccount() as part of the OCS API extension.

[PVince81]

OCS API has been adjusted.

Next up: unit tests

[PVince81]

unit tests done

next up would be fixing guest avatar performance, but could also be done separately as the current approach already works

however, still need to settle at least on wording and icons

[PVince81]

Added task "add capability". I think a simple boolean should do to signal the ability to read and set scopes.

[PVince81]

• switch icons to material design ? (so that clients could use the same icon names from the MD library)

[PVince81]

Added capability:

        "provisioning_api": {
          "version": "1.11.0",
          "hasAccountPropertyScopes": true
        },

Added PlaceholderAvatar which is like GuestAvatar but caches the images.
This was done separately to avoid messing with existing UserAvatar logic and their own existing generated images, which would require more logic and migration to make it work right.

[nickvergessen]

Earn bonus points for expanding https://github.com/nextcloud/server/blob/master/build/integration/features/provisioning-v1.feature

[PVince81]

Earn bonus points for expanding https://github.com/nextcloud/server/blob/master/build/integration/features/provisioning-v1.feature

done

[nickvergessen]

Wording and icons to discuss, but works technically

[PVince81]

rebased for CI

[PVince81]

/drone/src/tests/acceptance/features/app-files-sharing.feature:23 again ?! 😦

[PVince81]

can someone force merge maybe ? seems the notifications app might be cached or something... in any case, the test failure is unrelated

[nickvergessen]

/backport to stable21