Skip to content

[stable19] Catch invalid cache source storage path #26273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 1 commit into from
Mar 24, 2021
Merged

[stable19] Catch invalid cache source storage path #26273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Catch invalid cache source storage path 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
  • Loading branch information
@skjnldsv @backportbot
skjnldsv authored and backportbot[bot] committed Mar 24, 2021
commit c74a10ddb4b86b87e1ea7fab611d25ba53f23bc1
4 changes: 4 additions & 0 deletions lib/private/Files/Cache/Cache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,10 @@ public function moveFromCache(ICache $sourceCache, $sourcePath, $targetPath) {
$targetPath = $this->normalize($targetPath);

$sourceData = $sourceCache->get($sourcePath);
if ($sourceData === false) {
throw new \Exception('Invalid source storage path: ' . $sourcePath);
}

$sourceId = $sourceData['fileid'];
$newParentId = $this->getParentId($targetPath);

Expand Down