[stable21] Fix casing of core test folder, bring back missing tests #26276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems Phpunit < 9 was case insensitive. Fixed the phpunit config to target the correct name for the "Core" test directory. Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
Remove "ocs-provider" test folder reference as it doesn't exist any more. Added back "Test" test subdir and fixed the tests inside. Signed-off-by: Vincent Petry <[email protected]>
Fixes issue with Oracle by enforcing the order of the results to check. Signed-off-by: Vincent Petry <[email protected]>
backportbot-nextcloud
bot
requested review from
ChristophWurst,
MorrisJobke,
PVince81,
kesselb,
nickvergessen and
rullzer
MorrisJobke
approved these changes
Mar 24, 2021
Member
Aha, so that change was only needed on master where we switched to IEventDispatcher. |
Signed-off-by: Vincent Petry <[email protected]>
nickvergessen
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #26265