Skip to content

[stable21] Only mark migrations as installed after execution #26379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Mar 31, 2021
Merged

[stable21] Only mark migrations as installed after execution #26379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Only mark migrations as installed after execution 
The problem is that if a developer creates a structural error in their migration file,
they will already be marked as executed and an not be rerun.

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @backportbot
nickvergessen authored and backportbot[bot] committed Mar 30, 2021
commit e3927afe195dc1fe385baf00439de18096bbcd22
6 changes: 4 additions & 2 deletions lib/private/DB/MigrationService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,8 +453,6 @@ public function migrateSchemaOnly($to = 'latest') {
$toSchema = $instance->changeSchema($this->output, function () use ($toSchema) {
return $toSchema ?: new SchemaWrapper($this->connection);
}, ['tablePrefix' => $this->connection->getPrefix()]) ?: $toSchema;

$this->markAsExecuted($version);
}

if ($toSchema instanceof SchemaWrapper) {
Expand All @@ -466,6 +464,10 @@ public function migrateSchemaOnly($to = 'latest') {
$this->connection->migrateToSchema($targetSchema);
$toSchema->performDropTableCalls();
}

foreach ($toBeExecuted as $version) {
$this->markAsExecuted($version);
}
}

/**
Expand Down