Limit size of properties to 2048 characters #26433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasReschke
force-pushed
the
limit-max-length-of-properties
branch
from
4d5b1c4 to
b1084ec
Compare
LukasReschke
force-pushed
the
limit-max-length-of-properties
branch
from
ed8ccad to
44b25ef
Compare
nickvergessen
approved these changes
Apr 7, 2021
rullzer
approved these changes
Apr 8, 2021
rullzer
force-pushed
the
limit-max-length-of-properties
branch
from
44b25ef to
2befac6
Compare
It is unreasonable to expect that one of these fields would be longer than 2048 characters. Whilst some have definitely lower limits (such as for phone numbers or domain names), a upper bound as sanity check makes sense. Signed-off-by: Lukas Reschke <[email protected]>
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
LukasReschke
added a commit
that referenced
this pull request
Apr 13, 2021
It is unreasonable to expect that one of these fields would be longer than 2048 characters. Whilst some have definitely lower limits (such as for phone numbers or domain names), a upper bound as sanity check makes sense. Backport of #26433 Signed-off-by: Lukas Reschke <[email protected]>
LukasReschke
added a commit
that referenced
this pull request
Apr 13, 2021
It is unreasonable to expect that one of these fields would be longer than 2048 characters. Whilst some have definitely lower limits (such as for phone numbers or domain names), a upper bound as sanity check makes sense. Backport of #26433 Signed-off-by: Lukas Reschke <[email protected]>
rullzer
pushed a commit
that referenced
this pull request
Apr 29, 2021
It is unreasonable to expect that one of these fields would be longer than 2048 characters. Whilst some have definitely lower limits (such as for phone numbers or domain names), a upper bound as sanity check makes sense. Backport of #26433 Signed-off-by: Lukas Reschke <[email protected]>
rullzer
pushed a commit
that referenced
this pull request
Apr 29, 2021
It is unreasonable to expect that one of these fields would be longer than 2048 characters. Whilst some have definitely lower limits (such as for phone numbers or domain names), a upper bound as sanity check makes sense. Backport of #26433 Signed-off-by: Lukas Reschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.