Skip to content

Fix accessibility issues on log in screen #26521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Apr 13, 2021
Merged

Fix accessibility issues on log in screen #26521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcf044a
Fix password visibility toggle alt text and hover/focus feedback
jancborchardt Apr 12, 2021
294ddf7
Fix log in button hover/focus feedback
jancborchardt Apr 12, 2021
bdd5667
Fix 'Log in with a device' link focusability
jancborchardt Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions core/css/guest.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,14 @@ input[type='password'].password-with-toggle, input[type='text'].password-with-to
}
.toggle-password {
position: absolute;
top: 17px;
right: 20px;
top: 1px;
right: 5px;
padding: 14px;
height: 16px;
}
.toggle-password:hover,
.toggle-password:focus {
opacity: .6;
}
input.login {
width: 260px;
Expand Down Expand Up @@ -334,7 +340,9 @@ button.primary:not(:disabled):hover,
button.primary:not(:disabled):focus,
a.primary:not(:disabled):hover,
a.primary:not(:disabled):focus {
color: rgba(255, 255, 255, .8);
color: rgba(255, 255, 255, 1);
background-image: linear-gradient(40deg, #0082c9 0%, #30b6ff 100%);
background-position: initial;
}

/* Checkboxes - white only for login */
Expand Down
4 changes: 2 additions & 2 deletions core/js/dist/login.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/js/dist/login.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/src/components/login/LoginForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
<label for="password"
class="infield">{{ t('Password') }}</label>
<a href="#" class="toggle-password" @click.stop.prevent="togglePassword">
<img :src="toggleIcon">
<img :src="toggleIcon" :alt="t('core', 'Toggle password visibility')">
</a>
</p>

Expand Down
6 changes: 4 additions & 2 deletions core/src/views/Login.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@
{{ t('core', 'Forgot password?') }}
</a>
<br>
<a v-if="hasPasswordless" @click.prevent="passwordlessLogin = true">
<a v-if="hasPasswordless"
href="#"
@click.prevent="passwordlessLogin = true">
{{ t('core', 'Log in with a device') }}
</a>
</div>
Expand All @@ -61,7 +63,7 @@
:is-https="isHttps"
:has-public-key-credential="hasPublicKeyCredential"
@submit="loading = true" />
<a @click.prevent="passwordlessLogin = false">
<a @click.prevent="passwordlessLogin = false" href="#">
{{ t('core', 'Back') }}
</a>
</div>
Expand Down