Skip to content

ensure redis returns bool for hasKey #26551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 1 commit into from
Apr 14, 2021
Merged

ensure redis returns bool for hasKey #26551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/Http/Client/NegativeDnsCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ public function setNegativeCacheForDnsType(string $domain, int $type, int $ttl)
}

public function isNegativeCached(string $domain, int $type) : bool {
return $this->cache->hasKey($this->createCacheKey($domain, $type));
return (bool)$this->cache->hasKey($this->createCacheKey($domain, $type));
}
}
2 changes: 1 addition & 1 deletion lib/private/Memcache/Redis.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public function set($key, $value, $ttl = 0) {
}

public function hasKey($key) {
Copy link
Member

@rullzer rullzer Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we type the signature as well?

Copy link
Member Author

@blizzz blizzz Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be done in the interface, didn't want to change that. For 22 should be ok. And just backport that line.

Copy link
Member Author

@blizzz blizzz Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but then let's refurbish the whole ICache in a follow up PR since it is mostly from 2013.

return self::$cache->exists($this->getNameSpace() . $key);
return (bool)self::$cache->exists($this->getNameSpace() . $key);
}

public function remove($key) {
Expand Down