Skip to content

Conversation

@juliusknorr
Copy link
Member

This PR makes sure to properly check if a path is provided before trying to create a file in a folder.

This can become an issue when using object storage if some code calls newFile with an empty string for some reason. The ObjectStoreStorage would in that case try to detect the mimetype by path and update the parent folder (as the path is empty) with an application/octet-stream mimetype in the filecache.

@juliusknorr
Copy link
Member Author

if some code calls newFile with an empty string for some reason

That might be text as for one case where this issue occured, but still investigating to catch the root cause as well.

@rullzer
Copy link
Member

rullzer commented Apr 20, 2021

if some code calls newFile with an empty string for some reason

That might be text as for one case where this issue occured, but still investigating to catch the root cause as well.

Well now tey should have some kind of stack trace somewhere ;)

@rullzer rullzer merged commit f31d24d into master Apr 20, 2021
@rullzer rullzer deleted the bugfix/noid/empty-filename branch April 20, 2021 18:47
@juliusknorr
Copy link
Member Author

/backport to stable21

@juliusknorr
Copy link
Member Author

/backport to stable20

@juliusknorr
Copy link
Member Author

/backport to stable19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants