Skip to content

Fix share creation insert and get #26716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Sep 2, 2023
Merged

Fix share creation insert and get #26716

skjnldsv merged 1 commit into from
Sep 2, 2023

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 23, 2021 •
edited
Loading

Instead of getting the last inserted row data when creating a share, just get update the iShare we have on hand.

@skjnldsv skjnldsv added this to the Nextcloud 22 milestone Apr 23, 2021
@skjnldsv skjnldsv self-assigned this Apr 23, 2021
@skjnldsv skjnldsv mentioned this pull request Apr 23, 2021
Merged
@skjnldsv skjnldsv changed the title Add proper message to created share not found Fix sharing creation insert and get Apr 23, 2021
@skjnldsv skjnldsv changed the title Fix sharing creation insert and get Fix share creation insert and get Apr 23, 2021
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 23, 2021

Some tests fails

OCP\Share\Exceptions\IllegalIDChangeException: Not allowed to assign a new internal id to a share

rullzer
rullzer reviewed Apr 23, 2021
View reviewed changes
This was referenced May 20, 2021
Merged
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 May 26, 2021
@blizzz blizzz modified the milestones: Nextcloud 23, Nextcloud 22 Jun 24, 2021
@blizzz blizzz mentioned this pull request Jul 1, 2021
Merged
3 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jul 1, 2021
@MorrisJobke MorrisJobke removed their request for review July 4, 2021 11:34
@nextcloud-command nextcloud-command force-pushed the enh/better-share-exceptiondebug branch from 3612a10 to e3fa686 Compare August 18, 2021 12:47
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 13, 2021
Base automatically changed from enh/better-share-exceptiondebug to master October 13, 2021 09:41
@skjnldsv skjnldsv force-pushed the fix/sharing-do-no-get-after-create branch 2 times, most recently from edaf74f to fa76b87 Compare May 3, 2023 08:50
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, artonge and come-nc and removed request for a team and blizzz May 3, 2023 08:50
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 3, 2023
@skjnldsv skjnldsv force-pushed the fix/sharing-do-no-get-after-create branch 2 times, most recently from 1f6ff7b to 20c342f Compare May 4, 2023 13:18
@skjnldsv
Copy link
Member Author

skjnldsv commented May 4, 2023

Fixed tests

@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels May 5, 2023
This was referenced May 9, 2023
Closed
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv force-pushed the fix/sharing-do-no-get-after-create branch 2 times, most recently from bcfea90 to 3087dcd Compare September 2, 2023 08:01
@skjnldsv
Fix sharing creation insert and get
f828dce 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/sharing-do-no-get-after-create branch from 3087dcd to f828dce Compare September 2, 2023 08:25
@skjnldsv skjnldsv enabled auto-merge September 2, 2023 08:51
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 2, 2023
@skjnldsv skjnldsv merged commit db5dbd1 into master Sep 2, 2023
@skjnldsv skjnldsv deleted the fix/sharing-do-no-get-after-create branch September 2, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer left review comments

@icewind1991 icewind1991 icewind1991 approved these changes

@artonge artonge artonge approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

7 participants

@skjnldsv @PVince81 @blizzz @icewind1991 @rullzer @artonge