Clean up DB code in the CalDAV backend #26719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
aleister09,
artemanufrij,
brantje,
kesselb,
miaulalala,
nickvergessen,
rullzer and
tcitworld
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
chore/dav-cleanup-query-usage
branch
from
2e8149e to
11d3ae1
Compare
nickvergessen
previously requested changes
Apr 23, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Infinite loop in CalDavBackend
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
chore/dav-cleanup-query-usage
branch
from
11d3ae1 to
323f956
Compare
nickvergessen
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executeQueryandexecuteUpdateas replacement of the deprecatedexecuteThose three steps are split into separate commits. You may review individually.
Found while working on #26083.