Skip to content

Fixed username and domain separation in getACL #26738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Snafu wants to merge 2 commits into from
Closed

Fixed username and domain separation in getACL #26738

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2df89a
Fixed getACL to return the username without domain
Snafu Apr 24, 2021
5616fda
Fixed username containing separator if workgroup is empty
Snafu Apr 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed getACL to return the username without domain 
Inspired by anikrooz commit
1f95f9b

Signed-off-by: Christopher Gabriel <[email protected]>
  • Loading branch information
@Snafu
Snafu committed Apr 24, 2021
commit d2df89a02f31ac508b1d1cf9803fb9b2dced2de4
2 changes: 1 addition & 1 deletion apps/files_external/lib/Lib/Storage/SMB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ protected function throwUnavailable(\Exception $e) {
private function getACL(IFileInfo $file): ?ACL {
$acls = $file->getAcls();
foreach ($acls as $user => $acl) {
[, $user] = explode('\\', $user); // strip domain
[, $user] = $this->splitUser($user); // strip domain
if ($user === $this->server->getAuth()->getUsername()) {
return $acl;
}
Expand Down