Don't break OCC if an app is breaking in it's Application class #26878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ChristophWurst,
MorrisJobke,
kesselb and
rullzer
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
ChristophWurst
approved these changes
May 5, 2021
kesselb
reviewed
May 5, 2021
nickvergessen
deleted the
bugfix/noid/dont-break-occ-when-an-app-is-breaking-in-application-class
branch
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
|
The backport to stable21 failed. Please do this backport manually. |
This was referenced May 5, 2021
|
The backport to stable20 failed. Please do this backport manually. |
MorrisJobke
reviewed
May 5, 2021
| try { | ||
| self::loadApp($app); | ||
| } catch (\Throwable $e) { | ||
| \OC::$server->get(LoggerInterface::class)->emergency('Error during app loading: ' . $e->getMessage(), [ |
Member
There was a problem hiding this comment.
This will then cause the app not being disabled anymore on errors, right? IMO a good thing 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
implements IBackendProviderpart in the Application class only for enabling