better cleanup of filecache when deleting an external storage #26936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
reviewed
May 10, 2021
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
I like the simplification. Should the deletes not be within a transaction, though?
icewind1991
force-pushed
the
external-storage-delete-clean
branch
from
5de321f to
1423912
Compare
Member
Author
makes sense, done |
blizzz
approved these changes
May 11, 2021
blizzz
added
4. to release
Member
|
Tests fail now. |
MorrisJobke
added
2. developing
icewind1991
force-pushed
the
external-storage-delete-clean
branch
2 times, most recently
from
39c700a to
599a4da
Compare
Member
|
Still failing :/ |
icewind1991
force-pushed
the
external-storage-delete-clean
branch
2 times, most recently
from
ff830ea to
debb440
Compare
MorrisJobke
added
4. to release
this way it can delete the cache entries even with per-user credentials Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
external-storage-delete-clean
branch
from
debb440 to
ed2396b
Compare
Member
Author
|
CI happy |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
|
/backport to stable21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way it can delete the cache entries even with per-user credentials
Fixes #26842