Skip to content

Fix log error when creating files from an empty template #26963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
May 19, 2021
Merged

Fix log error when creating files from an empty template #26963

rullzer merged 1 commit into from
May 19, 2021

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 12, 2021 •
edited
Loading

Without the event might be called with an undefined variable in

server/lib/private/Files/Template/TemplateManager.php

Line 176 in d55f83f

$this->eventDispatcher->dispatchTyped(new FileCreatedFromTemplateEvent($template, $targetFile));

Fixes #26817

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels May 12, 2021
@juliusknorr juliusknorr added this to the Nextcloud 22 milestone May 12, 2021
This was referenced May 12, 2021
Closed
Closed
@juliusknorr
Copy link
Member Author

juliusknorr commented May 12, 2021

/backport to stable21

@AndyXheli
Copy link
Contributor

AndyXheli commented May 12, 2021 •
edited
Loading

Applied the changes; looks like this fixed it ##26817 Thank you!

@rullzer rullzer force-pushed the bugfix/noid/empty-template-error branch from d55f83f to b8d0249 Compare May 18, 2021 08:23
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 18, 2021
@juliusknorr
Copy link
Member Author

juliusknorr commented May 18, 2021

Retriggered drone

@rullzer rullzer merged commit aa785d2 into master May 19, 2021
@rullzer rullzer deleted the bugfix/noid/empty-template-error branch May 19, 2021 06:46
@MorrisJobke
Copy link
Member

MorrisJobke commented May 19, 2021

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 19, 2021
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented May 19, 2021

The backport to stable21 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@enochterrymize enochterrymize Awaiting requested review from enochterrymize

@julien-nc julien-nc Awaiting requested review from julien-nc

+1 more reviewer

@AndyXheli AndyXheli AndyXheli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

Error: Undefined variable: template at /var/www/nextcloud/lib/private/Files/Template/TemplateManager.php#174

5 participants

@juliusknorr @AndyXheli @MorrisJobke @rullzer