Skip to content

Run s3 tests again #27198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukasReschke merged 2 commits into from
Jul 5, 2021
Merged

Run s3 tests again #27198

LukasReschke merged 2 commits into from
Jul 5, 2021

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 28, 2021 •
edited
Loading

  • reenable s3/azure tests
  • check for alternatives to fake-s3 as it does not support multipart uploads -> using minio now

LukasReschke
LukasReschke reviewed May 28, 2021
View reviewed changes
@juliusknorr
Run s3 tests again
3f44fd0 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Use minio for s3 tests
55cabef 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr force-pushed the tests/run-s3-tests branch from 8ba917a to 55cabef Compare July 1, 2021 06:22
juliusknorr
juliusknorr commented Jul 1, 2021
View reviewed changes
.drone.yml
steps:
- name: minio
image: ghcr.io/nextcloud/continuous-integration-minio:latest
detach: true
Copy link
Member Author

@juliusknorr juliusknorr Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to move this to a detached step to properly pass the commands starting the server

@juliusknorr juliusknorr marked this pull request as ready for review July 1, 2021 06:23
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 1, 2021

/backport to stable22

@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 1, 2021

/backport to stable21

@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 1, 2021

/backport to stable20

LukasReschke
LukasReschke approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error seems unrelated

@LukasReschke LukasReschke merged commit 415d704 into master Jul 5, 2021
@LukasReschke LukasReschke deleted the tests/run-s3-tests branch July 5, 2021 09:52
This was referenced Jul 5, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: object storage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @LukasReschke @skjnldsv