Skip to content

[stable21] Fix Oracle query limit compliance in Comments #27203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 3 commits into from
Sep 27, 2021
Merged

[stable21] Fix Oracle query limit compliance in Comments #27203

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f325a4a
Fix Oracle query limit compliance in Comments
Simounet May 27, 2021
8e7eea9
Fix populating the array and closing the cursors
nickvergessen Jun 1, 2021
1297b04
Use legacy execute method
artonge Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use legacy execute method 
Use legacy execute method instead of executeQuery introduced in 22

Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed Sep 23, 2021
commit 1297b04d41a934d52acd91d406800210dcb653d0
2 changes: 1 addition & 1 deletion lib/private/Comments/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ public function getNumberOfUnreadCommentsForObjects(string $objectType, array $o
foreach (array_chunk($objectIds, 1000) as $chunk) {
$query->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY);

$result = $query->executeQuery();
$result = $query->execute();
while ($row = $result->fetch()) {
$unreadComments[$row['object_id']] = (int) $row['num_comments'];
}
Expand Down